Open walldiss opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 45.13%. Comparing base (
2469e7a
) to head (1756726
). Report is 372 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We need to discuss this before merging
The setting was allowing users to change amount of samples for light availability. The ability to set the value only causes users to misuse the setting:
Node can define hardcoded value, which should be part of protocol defined values for light nodes. From code perspective, hardcoded value and removal of settings will simplify the code of light availability as well as configuration options.