celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
932 stars 926 forks source link

refactor(availability/light): remove samples amount settings #3909

Open walldiss opened 3 weeks ago

walldiss commented 3 weeks ago

The setting was allowing users to change amount of samples for light availability. The ability to set the value only causes users to misuse the setting:

Node can define hardcoded value, which should be part of protocol defined values for light nodes. From code perspective, hardcoded value and removal of settings will simplify the code of light availability as well as configuration options.

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.13%. Comparing base (2469e7a) to head (1756726). Report is 372 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3909 +/- ## ========================================== + Coverage 44.83% 45.13% +0.29% ========================================== Files 265 308 +43 Lines 14620 21753 +7133 ========================================== + Hits 6555 9818 +3263 - Misses 7313 10875 +3562 - Partials 752 1060 +308 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Wondertan commented 3 weeks ago

We need to discuss this before merging