celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
932 stars 926 forks source link

feat!: adds support for gRPC streaming and removes dependency on RPC #3915

Open rach-id opened 2 weeks ago

rach-id commented 2 weeks ago

The Celestia-node part of https://github.com/celestiaorg/celestia-core/pull/1513

rach-id commented 2 weeks ago

PR still not fully ready, some tests are still failing. but would be good to get initial opinion + if someone can see if it's providing you with any performance increase

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 58.65922% with 74 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/api-breaks@4a90605). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/fetcher.go 54.96% 45 Missing and 23 partials :warning:
core/exchange.go 71.42% 2 Missing :warning:
nodebuilder/core/config.go 50.00% 2 Missing :warning:
core/listener.go 66.66% 1 Missing :warning:
nodebuilder/core/constructors.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/api-breaks #3915 +/- ## ===================================================== Coverage ? 45.09% ===================================================== Files ? 307 Lines ? 21843 Branches ? 0 ===================================================== Hits ? 9850 Misses ? 10904 Partials ? 1089 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

vgonkivs commented 1 week ago

conflicts cc @rach-id

rach-id commented 1 week ago

@vgonkivs Fixed 🙏 Would be good to know if this PR is good to go so that we start merging the changes in core/comsos-sdk

vgonkivs commented 1 week ago

Tested locally. Both grpc clients work