celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
932 stars 926 forks source link

deprecate the `func (s *Service) Included()` method after migration from heights to hashes #3919

Open rach-id opened 2 weeks ago

rach-id commented 2 weeks ago
          Since our API operates with header's height, deprecating this method requires users to download the header to get the hash.

So, I agree that we can deprecate this method in favour of proof public validate methods but only after migration from heights to hashes.

_Originally posted by @vgonkivs in https://github.com/celestiaorg/celestia-node/pull/3821#discussion_r1829356534_