search

celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
933 stars 928 forks source link

fix(header)!: use tmjson encoding for Commit field as well #3925

Closed renaynay closed 1 week ago

renaynay commented 2 weeks ago

Fixes #3918

Please note: this PR is BREAKING as header encoding has changed.

I don't see a reason we weren't doing this to begin with as we tmjson encode the other "tendermint" fields.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.10%. Comparing base (2469e7a) to head (5ebb191). Report is 378 commits behind head on main.

Files with missing lines Patch % Lines
header/header.go 50.00% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3925 +/- ## ========================================== + Coverage 44.83% 45.10% +0.27% ========================================== Files 265 307 +42 Lines 14620 21846 +7226 ========================================== + Hits 6555 9854 +3299 - Misses 7313 10912 +3599 - Partials 752 1080 +328 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.