search

celestiaorg / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Other
19 stars 33 forks source link

chore: bump to Go 1.22 #375

Closed rootulp closed 8 months ago

rootulp commented 8 months ago

This repo is still on Go 1.19 which makes it difficult to develop simultaneous on this repo + celestia-app or celestia-core because they're already on Go 1.22. By difficult, I mean:

  1. go mod tidy will try to bump the Go version in this repo
  2. VSCode's Go language server (gopls?) breaks because it's running Go 1.22.1 on a Go 1.19 codebase

To resolve, this PR bumps the Go version, celestia-core version (to fix incompatible pyroscope deps), setup-go version in CI, golangci-lint because previous version wasn't compatible with Go 1.22. Then fixed lint issues reported by newer golangci-lint.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.31%. Comparing base (0244d0c) to head (4950d8c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/celestiaorg/cosmos-sdk/pull/375/graphs/tree.svg?width=650&height=150&src=pr&token=QPoE0e3PbO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celestiaorg)](https://app.codecov.io/gh/celestiaorg/cosmos-sdk/pull/375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celestiaorg) ```diff @@ Coverage Diff @@ ## release/v0.46.x-celestia #375 +/- ## ============================================================ - Coverage 65.52% 64.31% -1.21% ============================================================ Files 666 761 +95 Lines 71213 76379 +5166 ============================================================ + Hits 46662 49123 +2461 - Misses 21964 24481 +2517 - Partials 2587 2775 +188 ``` [see 96 files with indirect coverage changes](https://app.codecov.io/gh/celestiaorg/cosmos-sdk/pull/375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celestiaorg)