celestiaorg / cosmos-sdk

:chains: A Framework for Building High Value Public Blockchains :sparkles:
https://cosmos.network/
Other
19 stars 33 forks source link

feat!: add migrator to the commit abci call #387

Closed cmwaters closed 7 months ago

cmwaters commented 7 months ago

This PR addresses the app hash bug identified in this issue: https://github.com/celestiaorg/celestia-app/issues/3167

It introduces a migrator struct to BaseApp which allows the application to handle adding and removing stores as well as performing module migrations to any store.

This needs to be done in Commit as we need to first write the changes on the current deliver tx branch of state, add and remove the stores from the MultiCommitStore and then create a new branch of state to perform the migrations on. Only once they are completed and written can we calculate the new app hash