bridge: flags - add --gateway.deprecated-endpoints; fix submit pfb namespace hack

celestiaorg / go-cnc

celestia-node REST client in Go.

Apache License 2.0

15 stars 8 forks source link

bridge: flags - add --gateway.deprecated-endpoints; fix submit pfb namespace hack #61

Closed tuxcanfly closed 1 year ago

tuxcanfly commented 1 year ago

Overview

This PR adds --gateway.deprecated-endpoints flag to the bridge node.

While here, also fix the namespace hack around submit pfb endpoint.

Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

tuxcanfly commented 1 year ago

Blocked by #62

MSevey commented 1 year ago

made draft until unblocked.

tuxcanfly commented 1 year ago

Cherry picked #60 as test needs both commits to work together.

codecov-commenter commented 1 year ago

Codecov Report

Merging #61 (184dd5c) into main (ec221ef) will decrease coverage by 0.37%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   37.14%   36.78%   -0.37%     
==========================================
  Files           3        3              
  Lines         175      174       -1     
==========================================
- Hits           65       64       -1     
  Misses         97       97              
  Partials       13       13

Impacted Files	Coverage Δ
client.go	`51.80% <100.00%> (-0.58%)`	:arrow_down: