search

celestiaorg / go-header

Go library with all the services needed to request, sync and store blockchain headers.
Apache License 2.0
17 stars 16 forks source link

fix(sync): Fix `total_synced` metric recording #124

Closed renaynay closed 8 months ago

renaynay commented 8 months ago

Fixes the total_synced metric such that it actually updates the total amount of synced headers rather than overriding the value every time (missed this during code review of #121)

codecov-commenter commented 8 months ago

Codecov Report

Merging #124 (f13c92c) into main (098c994) will increase coverage by 0.06%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   69.20%   69.27%   +0.06%     
==========================================
  Files          37       37              
  Lines        2981     2981              
==========================================
+ Hits         2063     2065       +2     
+ Misses        771      769       -2     
  Partials      147      147
Files Coverage Δ
sync/metrics.go 15.38% <0.00%> (ø)

... and 1 file with indirect coverage changes