Closed vgonkivs closed 5 months ago
Attention: 75 lines
in your changes are missing coverage. Please review.
Comparison is base (
28ff21c
) 63.60% compared to head (0070afe
) 63.03%. Report is 13 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
sync/metrics.go | 11.90% | 69 Missing and 5 partials :warning: |
sync/sync_head.go | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please note, that peer info is not shown on the second screenshot because only one node was running
@vgonkivs, this is a feature, not misc
Tracking requestHeaders time feels like a job for tracing rather than metrics. Mainly because traces would provide the same data as metrics with additional insights on sub operations/spans. Although, this two can co-exist with metrics for monitoring anomalies and traces specifically for debugging.
For completely synced metric. I think we should add it, as syncLoopStop or similar.
Tracing is easier for debugging, while metrics are handy to have general overview of app. Having request time histogram will help us to quickly spot that there are some issues and then proceed to traces to investigate with more details.
Completed sync it could be a isSyncedGauge
, that does simple async if check on internal syncer state.
For request time it would be great to have syncRequestTimeHist
, which could track requests finished with their execution time.
From our quick sync with @walldiss, we agreed to add a few more metrics:
syncLoopGauge -> why can't we have a simple atomic with values 1/0? It will be enough I believe.
please advice on bucketing(might need opentelemetry bump)
-> I have tried buckets in the node repo but it hasn't worked for me.
Overview
Add metrics to syncer
Checklist