Closed vgonkivs closed 5 months ago
Attention: 17 lines
in your changes are missing coverage. Please review.
Comparison is base (
28ff21c
) 63.60% compared to head (2d1debb
) 64.11%. Report is 10 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
p2p/exchange_metrics.go | 0.00% | 12 Missing :warning: |
p2p/subscriber_metrics.go | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Overview
Previously some metrics did not work in the p2p package because Otel does not allow registering multiple callbacks per
otel.Meter
instance. At some point tracked/disconnected/blocked metrics were overwritten by subscription metric callback. Added singlemetric.Registration
in exchange client and created a separate instance for subscriber metrics.Checklist