fix(store): stop doing header verification in GetRangeByHeight

celestiaorg / go-header

Go library with all the services needed to request, sync and store blockchain headers.

Apache License 2.0

17 stars 16 forks source link

fix(store): stop doing header verification in GetRangeByHeight #180

Closed cristaloleg closed 1 month ago

cristaloleg commented 1 month ago

Overview

We don't need to verify headers on every GetRangeByHeight 'cause verification already happened in Append. No tests failed, added TestStore_Append_BadHeader to prevent bugs in the future.

Fixes #135

cristaloleg commented 1 month ago

Thanks friends, waiting for Rene to take a look.

cristaloleg commented 1 month ago

@renaynay kindly ping :)