celestiaorg / go-header

Go library with all the services needed to request, sync and store blockchain headers.
Apache License 2.0
17 stars 16 forks source link

store: `HeightSub` should be able to notify callers of *any* new height written to the Store #202

Open renaynay opened 4 days ago

renaynay commented 4 days ago

Currently, heightSub keeps track of height which essentially the highest height written to the Store. Since Store now allows non-adjacent Appends, that height field is rendered useless (at least in the case of heightSub) as it is not guaranteed that the highest header written to the store means that everything below is also written to the store.

Requested changes

renaynay commented 4 days ago

Maybe #197 contains valuable code for this implementation too