celestiaorg / go-header

Go library with all the services needed to request, sync and store blockchain headers.
Apache License 2.0
19 stars 18 forks source link

bug(sync): change error type to string #81

Closed vgonkivs closed 1 year ago

vgonkivs commented 1 year ago

Overview

Change error type to string in order to marshal/unmarshal it correctly closes #66

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #81 (7aa2164) into main (1ce71fd) will increase coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   65.94%   65.97%   +0.02%     
==========================================
  Files          35       35              
  Lines        2834     2836       +2     
==========================================
+ Hits         1869     1871       +2     
  Misses        811      811              
  Partials      154      154              
Impacted Files Coverage Δ
sync/sync.go 63.00% <0.00%> (-1.33%) :arrow_down:

... and 1 file with indirect coverage changes

Wondertan commented 1 year ago

@vgonkivs, could you address https://github.com/celestiaorg/go-header/issues/66#issuecomment-1629020766?

vgonkivs commented 1 year ago

made in a subsequent PR https://github.com/celestiaorg/go-header/pull/82