search

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

fix: add commands for generating go types #16

Closed cmwaters closed 8 months ago

cmwaters commented 8 months ago

Closes: #13

cmwaters commented 8 months ago

Note: I'm observing that when I run make proto-gen-docker or make proto-gen, there are changes to these files:

We might have different versions - let me dig into it

rootulp commented 8 months ago

If it helps debug:

$ buf --version
1.28.1
docker images

bufbuild/buf                                  latest    5085a683a6ba   3 months ago    55.4MB
staheri14 commented 8 months ago

Note: I'm observing that when I run make proto-gen-docker or make proto-gen, there are changes to these files:

  modified:   merkle/proto/proof.pb.go
  modified:   pkg/blob/blob.pb.go

It is the case for me too.

cmwaters commented 8 months ago

Okay I had an older version of buf. I'm going to hardcode the version to 1.28.1 in the Makefile so hopefully that produces constant results

rootulp commented 8 months ago

Hmm we need to update settings on this repo so that new commits dismiss previous PR approvals.

cmwaters commented 8 months ago

Hmm we need to update settings on this repo so that new commits dismiss previous PR approvals.

Done. I've also made it require two reviews like the other repos