celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

Path to publishing Go modules from this repo #20

Closed rootulp closed 7 months ago

rootulp commented 8 months ago

Problem

We're currently maintaining two copies of this code. One in this repo and one in https://github.com/celestiaorg/celestia-app

Proposal

Ideally we only maintain one copy of this code. A path to maintaining one copy of the code is:

  1. Publish Go modules from this repo. Optionally consider cutting a 1.0.0 release of this repo.
  2. Modify celestia-app to delete the duplicate code and instead depend on modules published by this repo.

We should probably enumerate a list of issues that need to be resolved prior to publishing these Go modules.

rootulp commented 7 months ago

@cmwaters already cut https://github.com/celestiaorg/go-square/releases/tag/v1.0.0-rc0 and is working on using it in celestia-app. See https://github.com/celestiaorg/celestia-app/pull/3026

so it seems like we don't need to enumerate a list of issues.