search

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

Enable dependabot #21

Closed rootulp closed 3 months ago

rootulp commented 8 months ago

Context

https://github.com/celestiaorg/go-square/blob/414d7f7849671d01b7055247a348fdca89b66ca0/go.mod#L3

Problem

It looks like dependabot isn't enabled on this repo because it uses Go 1.21.5 but Go 1.21.6 has been released

Acceptance Criteria

Enable dependabot

rootulp commented 3 months ago

I'm blocked b/c I don't have permission to see the settings on this repo.

@MSevey can you please give me admin or maintainer permissions on this repo?

cristaloleg commented 3 months ago

Why do we need to bump Go version in go.mod ?

Also, dependabot doesn't support that iirc.

rootulp commented 3 months ago

I think you're right b/c celestia-app has dependabot enabled and we've had to manually bump Go versions. But I think it's still a good idea to enable dependabot on this repo to bump the Go deps even though there aren't many.

cristaloleg commented 3 months ago

No-no, I'm about another thing which is not dependabot related: what is the reason to bump Go version in go.mod at all?

rootulp commented 3 months ago

So that we can use features from new Go releases.

cristaloleg commented 3 months ago

Fair enough. The only thing why I started this dialogue is that I saw go.mod bumps only when they are reaaaally needed. Also, Go patch releases don't give any language changes.

MSevey commented 3 months ago

I'm blocked b/c I don't have permission to see the settings on this repo.

@MSevey can you please give me admin or maintainer permissions on this repo?

done

rootulp commented 3 months ago

Dependabot was already enabled. I confirmed the config file looks good.

Screenshot

Screenshot 2024-05-29 at 11 05 30 AM