This repo shouldn't maintain Merkle tree implemenation

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction

Apache License 2.0

13 stars 17 forks source link

This repo shouldn't maintain Merkle tree implemenation #39

Closed Wondertan closed 4 months ago

Wondertan commented 8 months ago

merkle pkg contains Merkle tree extracted from Comet/Tendermint. This is a pretty standart RFC compatible Merkle tree implementation that should not be part of this repo. We should consider alternative and likely more efficient implementations out there, as depending on CometBFT is not an option for this repository.

rootulp commented 5 months ago

One idea that came up in a synchronous call is we could potentially make the Merkle tree in celestia-core a unique Go package and export it for consumption here so that we can delete the duplicate copy in this repo.

cristaloleg commented 5 months ago

This! For a new Celestia member for me it also was not that obvious why we've https://github.com/celestiaorg/smt (which is archived), why we've MT in go-square (and partially in celestia-core).