celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 17 forks source link

Consider removing `FitsInSquare` #4

Closed rootulp closed 9 months ago

rootulp commented 10 months ago

Context

https://github.com/celestiaorg/go-square/blob/1c0eefaa3ddb672a91d8d17e27202d3ff817c0c3/pkg/inclusion/blob_share_commitment_rules.go#L10-L16

https://github.com/celestiaorg/celestia-app/pull/2771

Problem

FitsInSquare is no longer used

Proposal

  1. Confirm no dependencies need this function
  2. Delete FitsInSquare
  3. Delete any relevant tests