search

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

Blob commitment uses hard coded subtree root threshold #5

Closed cmwaters closed 8 months ago

cmwaters commented 9 months ago

Summary

Ref: https://github.com/celestiaorg/celestia-app/blob/e0edb4cf0d89a08c46c5634d653e44a77d1d517c/pkg/inclusion/commitment.go#L34

Proposal

Should either pass the subtree root threshold by argument or a version number (most likely the former)

For Admin Use

rootulp commented 9 months ago

After https://github.com/celestiaorg/go-square/pull/1 merges should we move this issue to https://github.com/celestiaorg/go-square?

ninabarbakadze commented 8 months ago

I believe this issue has been resolved. @cmwaters @rootulp https://github.com/celestiaorg/go-square/blob/2562fc6b5b28f1bbb3b2a9d45007d185f7785b12/pkg/inclusion/commitment.go#L34

rootulp commented 8 months ago

Agreed, appears resolved by this commit