search

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

feat: add signer to blob proto #72

Closed cmwaters closed 2 months ago

cmwaters commented 2 months ago

First step is to simply add the signer to the protos. Then I will create the go native blob version and the constructors for v0 and v1 share versions

cmwaters commented 2 months ago

Out of curiosity, do you think it will be easier to add the signer field to the existing Blob type (a.k.a this PR) or create an entirely new type like BlobV2 with the signer field + all the fields in the current Blob.

I think they would be much the same. Proto was designed to be used this way (i.e. creating new fields in a backwards compatible manner)