celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

feat!: create native blob struct #74

Closed cmwaters closed 2 months ago

cmwaters commented 2 months ago

This builds on https://github.com/celestiaorg/go-square/pull/72

Closes: https://github.com/celestiaorg/go-square/issues/70

Note: this does not touch any of the share construction yet

cmwaters commented 2 months ago

I haven't added a maximum size check to the length of the signer. sdk.AccAddress is usually 20 bytes (the first 20 of a users public key), but in the SDK, I see a check of up to 255 bytes. Should I add one in here. Note that in celestia-app, we will have a specific check to see if it's a valid sdk.AccAddress and matches the signer of the PFB