search

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

chore!: rename shares to share #90

Closed cmwaters closed 2 months ago

cmwaters commented 2 months ago

Closes: https://github.com/celestiaorg/go-square/issues/88

cmwaters commented 2 months ago

I agree with this suggestion but we def don't have to do it in this PR. IMO optional if we want to include in the next breaking release

I think golangci-lint will complain until this is fixed

rootulp commented 2 months ago

We could add a golangci-lint ignore directive if you want to merge this first and do a separate PR for the rename from ShareSequence -> Sequence

cristaloleg commented 2 months ago

Share is a very good name for a variable. Just saying.

Reminds me net/url pain.

cmwaters commented 2 months ago

Share is a very good name for a variable. Just saying.

Reminds me net/url pain.

You're totally right. I had brought it up before when I wanted to call it something like enc for encoding or split