search

celestiaorg / go-square

A library for encoding blobs into a 2D square of evenly sized chunks designed for sampling and reconstruction
Apache License 2.0
13 stars 16 forks source link

chore!: remove merkle library #91

Closed cmwaters closed 2 months ago

cmwaters commented 2 months ago

This reverts commit fdf1e920e58a838598c959315a5c50b7f0ee54ce.

Closes: https://github.com/celestiaorg/go-square/issues/39

Wondertan commented 2 months ago

Shoot, we haven't decided what we do instead.

cmwaters commented 2 months ago

Shoot, we haven't decided what we do instead.

We're actually not using this library atm (we're still depending on the merkle library in celestia-core). I don't mind if we decide to spin out it's own repo, to make merkle it's own go.mod, or just leave it as is

Actually I'm wrong. We do use it so would have to revert back to celestia-core

rootulp commented 2 months ago

Note: there are usages of go-square/merkle in celestia-app (e.g. here) so I'm guessing those usages will need to be updated to celestia-core merkle instead when celestia-app bumps to go-square v2.

rootulp commented 2 months ago

go-square doesn't need to depend on celestia-core b/c nothing breaks if we remove the merkle package in this repo.

Wondertan commented 2 months ago

We do use it so would have to revert back to celestia-core

What does revert back mean?

rootulp commented 2 months ago

I think consumers of go-square/merkle (i.e. celestia-app) would have to revert back to consuming it from celestia-core.