Closed MSevey closed 4 months ago
[!WARNING]
Review failed
The pull request is closed.
The recent changes involve modifications to the .env
file, .github/workflows/knuu_testing.yml
, and the Makefile
. The .env
file's KNUU_TIMEOUT
setting was increased to 120 minutes, and the LOG_LEVEL
comment was clarified. The GitHub workflow was updated to trigger on specific branch pushes and support the merge_group
event. The Makefile
was simplified by removing the KNUU_TIMEOUT
environment variable setting for tests.
Files/Paths | Change Summaries |
---|---|
.env |
Increased KNUU_TIMEOUT from 60 to 120 minutes and clarified LOG_LEVEL comment. |
.github/workflows/knuu_testing.yml |
Adjusted branch specification for push events and added support for the merge_group event. |
Makefile |
Removed KNUU_TIMEOUT environment variable setting and associated timeout value from the test target. |
In the land of code, a rabbit hops, Tweaking timeouts, making stops. Workflows now so smart and keen, Testing flows like a dream. Makefile simpler, clean and bright, CodeRabbit's touch, pure delight. 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Overview
This PR:
I removed the -timeout flags as a default of 10m is sufficient. We have a .env file that we can use locally for the KNUU_TIMEOUT so I removed it from the command itself.Summary by CodeRabbit