celestiaorg / nmt

Namespaced Merkle Tree

Apache License 2.0

113 stars 39 forks source link

chore: removes the usage of the merkletree package #126

Closed staheri14 closed 1 year ago

staheri14 commented 1 year ago

Overview

Inline with #125. For more context, please see the following comment.

Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

codecov[bot] commented 1 year ago

Codecov Report

Merging #126 (f9f65fa) into master (e8ad2aa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files           6        6           
  Lines         464      464           
=======================================
  Hits          447      447           
  Misses         11       11           
  Partials        6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

staheri14 commented 1 year ago

Awesome, this LGTM after we remove the first line from

https://github.com/celestiaorg/nmt/blob/e8ad2aad94c115f8bb9d15786e544317b365b125/README.md?plain=1#L98-L99

Sure, good point, please see the revised version in https://github.com/celestiaorg/nmt/pull/126/commits/f9f65fad3ddcc6fc88ad64656cb13dc0c2daace3.