celestiaorg / nmt

Namespaced Merkle Tree
Apache License 2.0
112 stars 39 forks source link

feat!: remove ignore max namespace #168

Closed rootulp closed 1 year ago

rootulp commented 1 year ago

Related https://github.com/celestiaorg/nmt/issues/117

Experimental branch to see what breaks downstream if we removed the IgnoreMaxNamespace option.

codecov[bot] commented 1 year ago

Codecov Report

Merging #168 (bd6a7b4) into master (eb012d0) will decrease coverage by 0.51%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   96.20%   95.70%   -0.51%     
==========================================
  Files           6        6              
  Lines         527      512      -15     
==========================================
- Hits          507      490      -17     
- Misses         12       14       +2     
  Partials        8        8              
Impacted Files Coverage Δ
hasher.go 97.24% <100.00%> (-0.21%) :arrow_down:
nmt.go 99.00% <100.00%> (-0.03%) :arrow_down:
proof.go 93.75% <100.00%> (-0.06%) :arrow_down:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rootulp commented 1 year ago

No longer a candidate because celestia-node assumes the EDS row roots are constructed with IgnoreMaxNamespace=true so that it can efficiently find which row roots that correspond to a set of namespaced rows.