celestiaorg / nmt

Namespaced Merkle Tree
Apache License 2.0
112 stars 39 forks source link

feat!: checks the exact size of the node in HashNode #175

Closed staheri14 closed 1 year ago

staheri14 commented 1 year ago

Overview

Closes #153 (part of https://github.com/celestiaorg/nmt/issues/173)

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #175 (dd6a640) into master (2c15503) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files           5        5           
  Lines         519      519           
=======================================
  Hits          497      497           
  Misses         13       13           
  Partials        9        9           
Impacted Files Coverage Δ
hasher.go 97.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

staheri14 commented 1 year ago

this change seems like it could be consensus breaking if some nodes use it and others don't, so we might want to rename this PR to feat!... to indicate such a change

Right, updated the PR description.