feat: ensures consistent namespace hash format for all tree node parameters in VerifyInclusion function

celestiaorg / nmt

Namespaced Merkle Tree

Apache License 2.0

112 stars 39 forks source link

feat: ensures consistent namespace hash format for all tree node parameters in VerifyInclusion function #176

Closed staheri14 closed 1 year ago

staheri14 commented 1 year ago

Overview

Closes https://github.com/celestiaorg/nmt/issues/157 Closes https://github.com/celestiaorg/nmt/issues/161

Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

codecov[bot] commented 1 year ago

Codecov Report

Merging #176 (bcd45c3) into master (be509c3) will decrease coverage by 0.35%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   95.76%   95.41%   -0.35%     
==========================================
  Files           5        5              
  Lines         519      523       +4     
==========================================
+ Hits          497      499       +2     
- Misses         13       14       +1     
- Partials        9       10       +1

Impacted Files	Coverage Δ
proof.go	`92.30% <100.00%> (-1.50%)`	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

staheri14 commented 1 year ago

This PR has reduced the code coverage because it includes early consistency checks at the start of the VerifyInclusion function. As a result, certain code sections that were previously producing errors will no longer do so. Consequently, the corresponding lines will not be executed, leading to a decrease in code coverage.

evan-forbes commented 1 year ago

morge?