feat: returns error on invalid proof range in buildRangeProof

celestiaorg / nmt

Namespaced Merkle Tree

Apache License 2.0

112 stars 39 forks source link

feat: returns error on invalid proof range in buildRangeProof #182

Closed staheri14 closed 1 year ago

staheri14 commented 1 year ago

Overview

Closes #142

Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[x] Linked issues closed with keywords

codecov[bot] commented 1 year ago

Codecov Report

Merging #182 (d491b52) into master (21c6427) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   94.09%   94.14%   +0.05%     
==========================================
  Files           5        5              
  Lines         542      547       +5     
==========================================
+ Hits          510      515       +5     
  Misses         18       18              
  Partials       14       14

Impacted Files	Coverage Δ
nmt.go	`98.00% <100.00%> (+0.05%)`	:arrow_up:

staheri14 commented 1 year ago

LGTM. I'm assuming that the range includes start and excludes end right?

Yes, you are right, I added a comment to the function to make it more clear, please see https://github.com/celestiaorg/nmt/pull/182/commits/fcd3cd0b120447b85a002935dda0e2acc3530f93