search

celestiaorg / nmt

Namespaced Merkle Tree
Apache License 2.0
112 stars 39 forks source link

feat!: hex encode `id.String()` output #202

Closed rootulp closed 1 year ago

rootulp commented 1 year ago

This PR contains a breaking change that implements https://github.com/celestiaorg/nmt/pull/201#issuecomment-1564414023. Relevant https://github.com/celestiaorg/nmt/issues/200

staheri14 commented 1 year ago

@rootulp Is the PR ready for review? It says it is in draft mode :)

rootulp commented 1 year ago

It is not bc this PR is failing a test here

rootulp commented 1 year ago

Fixed failing test via https://github.com/celestiaorg/nmt/pull/203

codecov[bot] commented 1 year ago

Codecov Report

Merging #202 (9d77e95) into master (5466a61) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   95.40%   95.39%   -0.01%     
==========================================
  Files           5        5              
  Lines         566      565       -1     
==========================================
- Hits          540      539       -1     
  Misses         15       15              
  Partials       11       11
Impacted Files Coverage Δ
namespace/id.go 100.00% <ø> (ø)