celestiaorg / nmt

Namespaced Merkle Tree
Apache License 2.0
112 stars 39 forks source link

gobencher failure #204

Closed rootulp closed 1 year ago

rootulp commented 1 year ago

gobencher appears to fail on main: https://github.com/celestiaorg/nmt/runs/13789510043 and this PR: https://github.com/celestiaorg/nmt/pull/203/checks?check_run_id=13795230632

No benchmark results! rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing dial tcp 54.39.48.228:8888: connect: connection timed out"
rootulp commented 1 year ago

Tagging @elias-orijtech @odeke-em from Orjitech because https://dashboard.bencher.orijtech.com/ appears maintained by ya'll

rootulp commented 1 year ago

Proposal to disable gobencher b/c it's been failing consistently for 3+ weeks

rootulp commented 1 year ago

It's not a workflow in https://github.com/celestiaorg/nmt/tree/master/.github/workflows so it looks like a repo admin needs to disable the Github app on this repo. Tagging @MSevey

MSevey commented 1 year ago

It's not a workflow in https://github.com/celestiaorg/nmt/tree/master/.github/workflows so it looks like a repo admin needs to disable the Github app on this repo. Tagging @MSevey

I think we talked about this in the past with Ismail, since it isn't blocking we figured we would just leave it on for when it gets fixed since it is a useful tool. But it has been awhile so if the team feels like just removing it I can disable the app for the org.

Let's revisit in slack to get a quick consensus and then we can action it.

rootulp commented 1 year ago

Closing b/c looks like gobencher was removed from this repo

Screenshot 2023-06-21 at 1 42 34 PM