Closed vgonkivs closed 1 year ago
Merging #220 (4141b50) into master (3693c9a) will decrease coverage by
28.47%
. The diff coverage is6.20%
.
@@ Coverage Diff @@
## master #220 +/- ##
===========================================
- Coverage 93.67% 65.20% -28.47%
===========================================
Files 5 6 +1
Lines 601 891 +290
===========================================
+ Hits 563 581 +18
- Misses 21 293 +272
Partials 17 17
Impacted Files | Coverage Δ | |
---|---|---|
pb/proof.pb.go | 0.72% <0.72%> (ø) |
|
proof.go | 89.50% <100.00%> (+1.01%) |
:arrow_up: |
@vgonkivs do you mind if we rename the PR title to feat(proof):...
so that the squashed commit message conforms to conventional commits?
Yes, please. You can name it whatever fits you.
It looks good to me, thanks for updating the test style @vgonkivs! my only concern is the failing checks in Snyk for which I cannot see the details. @rootulp can you see the details?
Snyk claims this PR introduces 14 new vulnerabilities b/c the go.mod
changes. I don't think we should block the PR on it though
Thanks @rootulp for looking into this, I have created the tracking issue, feel free to add a snapshot of the Snyk errors in the issue for the record.
Overview
Added and generated a proto representation of the Proof
Checklist