Ignore proto generated files in codecover

celestiaorg / nmt

Namespaced Merkle Tree

Apache License 2.0

117 stars 43 forks source link

Ignore proto generated files in codecover #222

Open rootulp opened 1 year ago

rootulp commented 1 year ago

https://github.com/celestiaorg/nmt/pull/220 added Proto definitions to this repo. We don't need the generated proto files to be covered via unit tests so we should ignore them from the code coverage workflow that runs in this repo

Thanks for the idea @vgonkivs

staheri14 commented 1 year ago

Thanks for opening this issue! Do we want to proceed with this PR or do we want to wait for this fix before merging https://github.com/celestiaorg/nmt/pull/220?

rootulp commented 1 year ago

Let's proceed with https://github.com/celestiaorg/nmt/pull/220 and tackle this issue in a follow-up PR.

rootulp commented 2 weeks ago

This issue is close-able if we remove Code Coverage via https://github.com/celestiaorg/nmt/pull/282