search

celestiaorg / nmt

Namespaced Merkle Tree
Apache License 2.0
107 stars 39 forks source link

Github workflow for proto-gen #224

Open rootulp opened 1 year ago

rootulp commented 1 year ago

https://github.com/celestiaorg/nmt/pull/220 added Proto definitions to this repo. We should add a Github workflow that verifies the checked-in generated Proto files match what is expected if Proto is used to generated them. In other words, a CI workflow to catch if a maintainer has updated a *.proto file without also committing the updated generated *.pb.go file.

Workflows in celestia-app may be used for inspiration: https://github.com/celestiaorg/celestia-app/blob/6b2ad5e9f45cef8d734b2062b9f2158ed6c15f96/.github/workflows/protobuf.yml

Harsh-Daga commented 1 year ago

Hey @rootulp , I would like to work on this issue. Could you assign this to me?