Closed rootulp closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
main@e1faa53
). Click here to learn what that means. The diff coverage isn/a
.:exclamation: Current head 724cf01 differs from pull request most recent head 052f684. Consider uploading reports for the commit 052f684 to get more accurate results
@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage ? 80.83%
=======================================
Files ? 7
Lines ? 793
Branches ? 0
=======================================
Hits ? 641
Misses ? 110
Partials ? 42
Files Changed | Coverage Δ | |
---|---|---|
tree.go | 100.00% <ø> (ø) |
Closes https://github.com/celestiaorg/rsmt2d/issues/161 Blocked on https://github.com/celestiaorg/rsmt2d/pull/263
Testing
The
BenchmarkEDSRoots
benchmark behaves similarly before and after this PR. Since it is computing roots, I assume the SHA256 operations for minio/sha256-simd and Go 1.21's crypto/sha256 perform similarly.Before
After