search

celestiaorg / rsmt2d

Go implementation of two dimensional Reed-Solomon merkle tree data availability scheme.
Apache License 2.0
162 stars 80 forks source link

refactor: make consistent names for row and col indexes #317

Closed walldiss closed 7 months ago

walldiss commented 7 months ago

This PR standardizes index naming for rows and columns across the codebase to rowIdx and colIdx.

Resolves https://github.com/celestiaorg/rsmt2d/issues/314

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 86.13861% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 82.96%. Comparing base (d6c118c) to head (c116d1f). Report is 19 commits behind head on main.

Files Patch % Lines
extendeddatacrossword.go 75.00% 7 Missing and 2 partials :warning:
datasquare.go 89.13% 2 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #317 +/- ## ========================================== + Coverage 80.89% 82.96% +2.06% ========================================== Files 8 7 -1 Lines 869 628 -241 ========================================== - Hits 703 521 -182 + Misses 119 65 -54 + Partials 47 42 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.