celestiaorg / smt

A Go library that implements a Sparse Merkle tree for a key-value map.
https://godoc.org/github.com/celestiaorg/smt
MIT License
138 stars 53 forks source link

Modernize error handling #21

Closed tzdybal closed 3 years ago

tzdybal commented 3 years ago

Reference: https://blog.golang.org/go1.13-errors

tzdybal commented 3 years ago

@musalbas please make a final decision (see: https://github.com/lazyledger/smt/pull/21#pullrequestreview-600201662)

musalbas commented 3 years ago

Isn't this the wrong naming convention for sentinel value based errors? From the docs you linked, sentinel values start with Err.