Closed cuonglm closed 3 years ago
cc @odeke-em
Merging #42 (2066960) into master (072abf0) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 6 6
Lines 466 466
=======================================
Hits 401 401
Misses 37 37
Partials 28 28
Impacted Files | Coverage Δ | |
---|---|---|
treehasher.go | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 072abf0...2066960. Read the comment docs.
LGTM, thank you @cuonglm! Let's also see if we can shave off by reusing the hashers
Yeah, I think it can, but want to keep the PR as small as possible.
LGTM, thank you @cuonglm! Let's also see if we can shave off by reusing the hashers
Yeah, I think it can, but want to keep the PR as small as possible.
Absolutely, I meant to write/add "later on"
By doing two things:
That helps improves the sppeed, and less allocations for Update/Delete operations: