migrate to github actions

celestiaorg / smt

A Go library that implements a Sparse Merkle tree for a key-value map.

https://godoc.org/github.com/celestiaorg/smt

MIT License

138 stars 53 forks source link

migrate to github actions #9

Closed tac0turtle closed 3 years ago

tac0turtle commented 3 years ago

this repo needs github actions enabled

musalbas commented 3 years ago

This looks like it broke build and coverage tests?

tac0turtle commented 3 years ago

This looks like it broke build and coverage tests?

Not sure how to check, but this would break travisci. The reason I migrated from goveralls to codecov is to be consistent with ll-core. I can put goveralls back if you prefer it.

could you enable github actions to test this works

liamsi commented 3 years ago

@musalbas what is the state of this PR? IMO, it would be good if the CI and coverage tools were consistent between repos (if possible). If you want to merge this, I think you only need to generate a token for codecov (or Marko needs to change back to goveralls) and check the actions tab on the repo.

Otherwise, we should close the PR.

musalbas commented 3 years ago

Before this can merged, we need both build tests and coverage tests working, and the buttons on the readme should be up to date. Let me know what steps on my side would be needed from this. I cannot see any actions in action tab in the repo. I guess this has to be merged first? What about the readme buttons though?

tac0turtle commented 3 years ago

Let me know what steps on my side would be needed from this.

Are actions enabled in the settings tab? This should be able to run when not on master

musalbas commented 3 years ago

Yes:

liamsi commented 3 years ago

Action items:

[x] generate a codecov token: https://codecov.io/gh/lazyledger/smt (@musalbas)
[ ] update badges in readme (@marbar3778)
[ ] make sure this is actually run (@marbar3778 and @musalbas)

musalbas commented 3 years ago

Ok, I've generated a codecov token. Where do I need to add it? As a repository secret?

tac0turtle commented 3 years ago

Not sure if this has something to do with the branch coming from a fork, but it works in my repo (https://github.com/marbar3778/smt/pull/1).

No need to post the key anywhere. Its auto generated when using open source last I read

liamsi commented 3 years ago

my bad, the token is in fact not needed:

https://docs.codecov.io/docs/about-the-codecov-bash-uploader#upload-token

Sorry for the noise.

liamsi commented 3 years ago

Not sure if this has something to do with the branch coming from a fork, but it works in my repo (marbar3778#1).

If I understand the documentation correctly, it should be the other way around: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories

But I do remember that (using) circleci CI was not triggered when the PR came from a fork. I thought that changed when using github actions.