search

celguar / mangosbot-bots

Bot AI Core from ike3 for cmangos/mangos classic/tbc/wotlk
https://github.com/cmangos/playerbots
85 stars 42 forks source link

don't respond to commands with dialogue #323

Closed surraymb closed 6 months ago

surraymb commented 6 months ago

Added option to restore old equip upgrade behaviour - add "AiPlayerbot.OptimizeEquipUpgrading = 0" in config Added code for bots to ignore commands for dialogue responses, incomplete command list for now

mostlikely4r commented 6 months ago

Surraymb,

Thank you for your PR. Your changes look ok and we agree with the essence. Could you please make a seperate PR containing only the dialogue response fix?

For the equip upgrades change it looks like the code is just bugged. The equip upgrades now simply never triggered on item push and I don't think that was ever intented. We will do some testing and either fix it directly or implement a fancier solution to make it functional again. If all that fails we will come back to your suggested solution and use a config but only as last resort.

Thank you.

surraymb commented 6 months ago

Thank you!

I removed the equip upgrades commit from the PR