celguar / spp-classics-cmangos

SPP Classics repack with ike3 playerbots. Based on cmangos. Supports 1.12, 2.4.3, 3.3.5. Check "Releases" for installer
213 stars 58 forks source link

Account-wide Achievements, Pets, & Mounts #104

Closed ghost closed 9 months ago

ghost commented 1 year ago

Hi! Huge fan of the repack. I created an account-wide achievement, pet, and mount program and integrated it into the SPP Classics WotLK menu for personal use. I thought I’d share and submit my integration for your consideration.

The program is completely optional for users that don’t want to have account-wide achievements, pets, and mounts. For those that do use it, the program can be run whenever they want achievement, pets, or mounts shared/updated - the game will not handle transfers automatically.

The repo and release for the program can be found here: https://github.com/Domclay/spp-account-wide

The program essentially just runs a bunch of SQL queries and functions to fetch, transform/add to, and store updated achievement, pet, and mount data. I've thoroughly tested the program in-game and out, but of course, there's always the chance that uncaught bugs made it through, so I implemented a menu option to report issues to my repo's Issues tab should they arise.

Please let me know if you have any questions or concerns regarding the implementation, I’d love any feedback you might have!

General Overview

Features

Warnings/Limitations:

Lidocian commented 1 year ago

Nice!

Bot accounts are ignored? do you mean randombots? let them have it too.. ;)

Lidocian commented 1 year ago

i wan to see an achievment 10000 Honorable Kills on a randombot :)

DominicMonares commented 1 year ago

Apologies for the late response! I made this PR on a separate GitHub account before merging it with my main one, didn't get a notification.

Thank you for your feedback! That's correct about the random bots. I'm happy to make that change in my next implementation - I'm working on a larger scoped SPP app with more features that includes this one as part of it. I don't have an ETA on when that might be done yet unfortunately, I'm just getting back into the project after taking a break. Will submit a PR to replace this app as soon as it's done :)

celguar commented 1 year ago

Sounds good, thank you!

DominicMonares commented 1 year ago

Hello!

I've completed the new app that includes this account-wide functionality and submitted a PR (#171). Could you close this PR out for me please? I am unable to since this PR was submitted through my old account. Apologies for the inconvenience!