search

celguar / spp-classics-cmangos

SPP Classics repack with ike3 playerbots. Based on cmangos. Supports 1.12, 2.4.3, 3.3.5. Check "Releases" for installer
213 stars 58 forks source link

Wrong implementation of Solocraft #106

Open Slas1 opened 1 year ago

Slas1 commented 1 year ago

The solocraft setting are not multiplying a characters stats by a percentage, but is adding a flat bonus to a characters stats. That is not the functionality stated in the world.settings file. Ver: 2.2.9 - WotLK

Promised functionality: Taken from the world.settings file: Forumla: player->Stats (difficulty multiplier) Default: 100.0 0.0 (Disable) The functionality of the formula multiplies the player stats with the product of difficulty and multiplier. (based on the description it is multiplier/100)

Actual functionality The current implementation adds a flat value to the character stats. Forumla: player->Stats + (difficulty * multiplier)
(here the multiplier is not divided by 100)

I wastey prefer the promised functionality since what is good in deadmines is trash in wotlk intances. And making it scale on gear makes you feel strong when getting upgrades.

Blunderfluff commented 1 year ago

Yeah something seems off with it.

I just did Gundrak with a party of bots and my spellpower went up to 48,000. I have since disabled it.

Slas1 commented 1 year ago

From my test the pure spellpower added by solocraft work as intented based on the formular: level modifier difficulty. With a level 80 char in a level 80 dungeon with a default modifier in 2.5. 802.55 = 1000 Spellpower I gain the appropriate 1000 spellpower and 500 if I invite a bot into the dungeon. (Thereby halfling the difficulty)

I think you massive spellpower increase could have occurred if you have talents that allow spell-power to scale with stats. Like mages Mind Mastery in arcane (many classes have something like this). Then it could get a big boost from the wrongfully implemented Main Stats Part.

Blunderfluff commented 1 year ago

I'm not going to be much use here. The only thing I can add is that I was playing my resto druid who had a base of 2500 odd spellpower with Solocraft settings at default.

IIRC, the readout stated 200 bonus, but my actual bonus was something around 46,000. It was a while ago but I think it corrected itself at one point, possibly after re-entering the instance.

I'm personally not too fused about it as I don't really intend to use Solocraft functionality anyway. It looks like a pretty nice tool for those solo adventurers.