search

celguar / spp-classics-cmangos

SPP Classics repack with ike3 playerbots. Based on cmangos. Supports 1.12, 2.4.3, 3.3.5. Check "Releases" for installer
210 stars 57 forks source link

Could use simpler, less breaky versions of the batch files #158

Open DuendeInexistente opened 1 year ago

DuendeInexistente commented 1 year ago

So I already know porting this to linux would be a mess. I'm sure I'd find a lot of things corroborating this with a simple search on the issues.

But the batch files are... excessive? They depend on versions of commands (choice being the worst example) that are exclusive to windows 10 onwards and can't be ran under wine, have a lot of unnecessary flair that causes them to break even more under wine, and generally do not function at all. And are complicated enough that I can't make heads or tails of this after years of being spared working with windows batch, mostly due to the crazy amount of gotos.

All of which is to say, it'd be good if there were a set of batch files that each does one task and just that, with no animated menus necessitating fifty gotos. Downloading and installing a specific expansion, starting the server with it, etc.

celguar commented 1 year ago

I used repack on windows 7 with no issues

celguar commented 1 year ago

Animation is only during first start, and was only added 1 month ago, I don't remember any animations after that

celguar commented 1 year ago

I think best option would be to just have one folder with start MySQL, mangosd exe , realmd exe as other repacks have

celguar commented 1 year ago

But you probably right about choice, I didn't test that one below windows 10...

celguar commented 1 year ago

Also Linux builds now work, just need to make sure you have latest code of bots in src/modules folder. Vanilla/tbc at least are reported to be able to build and run