search

celiao / tmdbsimple

A wrapper for The Movie Database API v3.
GNU General Public License v3.0
579 stars 122 forks source link

Added request timeout setting #69

Closed hamza-jutt closed 2 years ago

hamza-jutt commented 4 years ago

Recently I've faced this issue twice where processes get stuck indefinitely until service is restarted. Both times the culprit was not having a timeout.

Also requests recommends adding a timeout in every request. More details can be found here.

hamza-jutt commented 4 years ago

@celiao Checks failed due to invalid API KEY. Can you debug if the encrypted secrets have been added correctly?

blakev commented 2 years ago

This is sorely needed.

celiao commented 2 years ago

Sorry for the delay, @hamza-jutt and @blakev. I will look at this next weekend, when I am home!

celiao commented 2 years ago

Thanks, @hamza-jutt! Check out how I changed your code to be more clean, consistent, and maintainable.

blakev commented 2 years ago

Will you push a pypi update?

celiao commented 2 years ago

Done! https://pypi.org/project/tmdbsimple/