Custom places icons

[mikebarkmin]

Would it be possible to update folder icons? For example, I use the nextcloud folder icon, but when I change the accent color, the nextcloud folder stays blue.

[DarkGhostHunter]

Same here. Changing a folder icon is then reverted to the default folder icon.

[celiopy]

Hello, changing accent color shouldn't mess with custom icons, so it would stay the one you've set by UI or by gio set command.

Also currently the extension can't address for custom icon either, so if you set the icon to, for example, folder-games under Adwaita-red, it will stay red if you change to accent green. The extension isn't able, in it's current form, to keep track of custom changes, but it is planned in future releases.

[DarkGhostHunter]

I can confirm, the icon stays the same with its color, but doesn't change to another accent color.

[celiopy]

Today's release, fix this. Any testing is more then welcome! Possible fixes all issues related to custom icons, the extension will update custom places that has icons based on Adwaita-colors variants to meet the set accent color, alongside icon theme.

[DarkGhostHunter]

https://github.com/user-attachments/assets/f0a68c31-c1da-4d2b-a467-ffc5cea4d07d

Tried to manually change the custom place icon in /var for a mounted volume and the color remained the same. The icon I choose was in /var/usrlocal/share/icons/Adwaita-green/scalable

[celiopy]

Tried to manually change the custom place icon in /var for a mounted volume

Right now the extension manipulates only directories under user home, I may be able to add more places for it to loop up to, but I can't guarantee it will work because of permissions issues that may arise.

Gravação de tela de 2024-11-21 12-27-21.webm

[jhawkins002]

Thanks for working on this. I have to install icons in /usr/share/icons because icons stored in /home tend to get buggy with some apps and are sometimes lost by Gnome after wake and unsuspend. I know this is not uncommon, so would be awesome to see support for non-home locations!

[celiopy]

Thanks for working on this. I have to install icons in /usr/share/icons because icons stored in /home tend to get buggy with some apps and are sometimes lost by Gnome after wake and unsuspend. I know this is not uncommon, so would be awesome to see support for non-home locations!

The extension accounts for directories with custom icon within user home, the icon itself could be anywhere, even on /usr/share/icons, the extension will just change the variant, e.g. Adwaita-red to Adwaita-green. For example:

Directory $HOME/Games has attribute (set by nautilus gui or gio set) metadata::custom-icon path is file:///home/$user/.local/share/icons/Adwaita-red/scalable/places/folder-games.svg will be changed to metadata::custom-icon: file:///home/io/.icons/Adwaita-green/scalable/places/folder-games.svg.

The same applies even if the icon is under /usr/share/icons, it doesn't matter for the extension, as it simply just replace the part of the path that points to a Adwaita-colors variant, nothing else. It just replaces the Adwaita- related part from the URI and sets the attribute to the directory.

What I meant before is that the extension won't handle updates icons for directories outside $HOME for now, because of safety concerns, I'm working on it, I pretend to add other directories such as /var to the loop.

[jhawkins002]

The extension accounts for directories with custom icon within user home, the icon itself could be anywhere, even on /usr/share/icons, the extension will just change the variant, e.g. Adwaita-red to Adwaita-green.

Oh!! Well unfortunately then I have to report it doesnt work as intended on my system - I have the most recent version of the extension installed and when customizing folder icons located in my /home directory the icons do not update with a color theme change.

[celiopy]

customizing folder icons located in my /home directory the icons do not update with a color theme change.

Could you please provide the full path to the custom icon you've set to the directory in question, the output of gio info -a metadata::custom-icon path/to/dir

[jhawkins002]

customizing folder icons located in my /home directory the icons do not update with a color theme change.

Could you please provide the full path to the custom icon you've set to the directory in question, the output of gio info -a metadata::custom-icon path/to/dir

Happy to! Iroinically it's a "games" folder haha: metadata::custom-icon: file:///usr/share/icons/Adwaita-slate/scalable/places/folder-games.svg

[celiopy]

Thank you, that path should be updated on accent change. Can you please also provide the path to the directory itself? Is it really within your home dir? Also did you reload nautilus view, it is never notified about the custom icon change, so it requires manually reload view

[jhawkins002]

Also did you reload nautilus view, it is never notified about the custom icon change, so it requires manually reload view

That was it!! I had been testing with an open window - I totally should have considered Nautilus would need a view reload. Apologies for the confusion and thank you for the quick follow-up!