search

cellannotation / cap-pipeline-config

Building ontology pipeline configurations for the Cell Annotation Platform
3 stars 0 forks source link

Mvp 1306 - Test for bringing in the tissue_list for organ cell semantic tags #50

Closed ghost closed 2 years ago

ghost commented 2 years ago

FYI @ubyndr, this will need refactoring to align with your python package / revised scripts, but I created this PR to start sharing the logic...

ubyndr commented 2 years ago

An update on python package usage, using local package rather than pypi package. fyi @bvarner-ebi

ghost commented 2 years ago

@ubyndr, do you think this PR will be subsumed / replaced by the work in #52? If so, does it make sense to discard or reappropriate it?

evanbiederstedt commented 2 years ago

I'm actually not sure what happened with this PR. Updates @ubyndr? CC @bvarner-ebi

ghost commented 2 years ago

I'm actually not sure what happened with this PR. Updates @ubyndr? CC @bvarner-ebi

This PR was originally made to test proof of concept, knowing it still needed engineering/technical input. I did not assign reviewers because it was still pending refinements and integrations with @ubyndr's updates before it would be ready for review.

Now that the autosuggest search pipeline plans have evolved, I'd like to get clarity on whether it makes sense to either scrap this PR because it will be replaced by work to be done in #52 or build from it if it fits in the current pipeline plans.

ubyndr commented 2 years ago

If so, does it make sense to discard or reappropriate it?

I think we can close this one, we can open a new PR when we have robot template for CAP organs