cellannotation / cap-pipeline-config

Building ontology pipeline configurations for the Cell Annotation Platform
3 stars 0 forks source link

Extend Disease tag to include PATO 'normal' #53

Closed dosumis closed 2 years ago

dosumis commented 2 years ago

In line with [CellXGene Anndata spec](), we need to allow PATO:normal in the Disease field. In the absence of this, we get some very bizarre suggestions for mappings for normal:

image

To achieve this we need to

(a) Load PATO into the KB (add https://github.com/pato-ontology/pato/blob/master/pato-base.owl to https://github.com/kharchenkolab/cap-pipeline-config/blob/main/config/collectdata/vfb_fullontologies.txt) (b) Add the Disease semantic tag to PATO normal, via a SPARQL query @bvarner-ebi

ubyndr commented 2 years ago

Are we going to keep this part in the yaml config? https://github.com/kharchenkolab/cap-pipeline-config/blob/ff287cc2a57187726408ccf937f9978e340780ee/config/prod/neo4j2owl-config.yaml#L218-L220

ubyndr commented 2 years ago

'development' branch is kinda default branch for this repository. pato.owl is already added to the vfb_fullontologies.txt, https://github.com/kharchenkolab/cap-pipeline-config/blob/ff287cc2a57187726408ccf937f9978e340780ee/config/collectdata/vfb_fullontologies.txt#L7. Do you only want to use the base version of the pato?

ubyndr commented 2 years ago
[Fatal Error] :16:76: Attribute name "crossorigin" associated with an element type "link" must be followed by the ' = ' character.
INVALID ONTOLOGY FILE ERROR Could not load a valid ontology from file: pato-base.owl
For details see: http://robot.obolibrary.org/errors#invalid-ontology-file-error

pato-base.owl has some issues, getting this error message in collectdata pipeline. Used pato.owl as I've mentioned in my previous comment. @dosumis

ghost commented 2 years ago

@ubyndr, can we close this ticket?

ubyndr commented 2 years ago

Yes, I have re-run the pipeline with the Prefix fix and indexes are ok. Just need to upload them to GCP so Denis can update the SOLR indexes on rc1 and prod.