search

cellannotation / cap-pipeline-config

Building ontology pipeline configurations for the Cell Annotation Platform
3 stars 0 forks source link

81 split manually edited from neo4j2owl config #82

Closed ubyndr closed 2 years ago

ubyndr commented 2 years ago

Fixes #81

I wasted a little bit of time while trying a fix an issue related with old DL queries for organ label. I had introduced an additional flag to generate the organ label DL queries from scratch. Than I release we don't need to do that since we start with manually edited file and add auto generated organ label DL queries on top of that, sorry...

github-actions[bot] commented 2 years ago

config/prod/neo4j2owl-config.yaml file passed validation check

ghost commented 2 years ago

@ubyndr, thank you for figuring out how to add multiple classes per organ label.

I notice that rerunning write_organ_tags.py resorts the classes (seemingly random) in neo4j2owl-config.yaml, which I don't think has a downstream impact. I also see that sometimes the DL queries under the classes are in different orders (see below). Again, don't think this has any impact, but just noticed.

  - classes:
      - RO:0002131 some UBERON:0002113
      - UBERON:0002113
    label: kidney
  - classes:
      - UBERON:0001705
      - RO:0002131 some UBERON:0001705
    label: nail
ubyndr commented 2 years ago

I've also noticed this but since it would not effect the functionality I didn't want to spend more time on this one. We can open an issue with low priority, and I can look into this once I have free time.