search

cellannotation / cas-tools

Cell Annotation Schema Tools
1 stars 0 forks source link

Cell set accession bug fix #98

Closed ubyndr closed 2 days ago

ubyndr commented 2 days ago

Issue: The issue arises when the same label appears in two different label sets. The lookup dictionary is created based on labels, which causes a conflict.

Details: Both the type EEC and leiden EEC labels appear in the lookup dictionary, resulting in only one entry for EEC. This conflict needs to be resolved to ensure proper functionality.

Solution: Use labelset:label instead of just label as keys in parent_cell_look_up dictionary operations.

hkir-dev commented 2 days ago

It seems that with this fix we are keeping both type:EEC and leiden:EEC in the CAS. Technically this fix seems good. But, can we confirm with curators if this is the intended output, or type:EEC and leiden:EEC are the same thing and we should only keep the highest or lowest level or keep both as you implemented.