cellannotation / cell-annotation-schema

General, open-standard schema for cell annotations
11 stars 2 forks source link

Suggested name change on cellannotation_set #1

Closed dosumis closed 1 year ago

dosumis commented 1 year ago

cellannotation_set --> cell_annotation_key

Set sounds like it might refer to a set of cell, or the set of all annotations using a particular key. I think key is much clearer and more generic. Will be less confusing for BICAN folks (I think) and maps more obviously onto key/value pairs in obs pandas series on each cell.

evanbiederstedt commented 1 year ago

I worry key sounds too database-y, though I'm happy to go along with this.

How about name?

cell_annotation_name?

It's something we'll need to revisit in the CAP UI anyways....I always said "labelset".

Screenshot 2023-09-04 at 3 12 02 PM

CC @unbelivr @rm1113 @mfutey for comments

mfutey commented 1 year ago

key might not be clear for some users, I think name is the better choice between the two.

dosumis commented 1 year ago

I think there's a real danger that cell_annotation_name would be confused with cell_label.

evanbiederstedt commented 1 year ago

setname? keyname? cell_set_name?

evanbiederstedt commented 1 year ago

Trying cellannotation_setname.

dosumis commented 1 year ago

I think that could work.